feat: Explicitly handle redaction #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/simplify-redaction-handling
branch
from
4c7de90 to
d1e6951
Compare
DafyddLlyr
commented
Oct 16, 2023
Comment on lines
+68
to
+69
| const responses = await $api.export.csvData(sessionId); | ||
| const redactedResponses = await $api.export.csvDataRedacted(sessionId); |
There was a problem hiding this comment.
This is the only place where both redacted and un-redacted payloads were used. This means that these two calls will now be slightly less efficient as the ExportClient is making additional requests to the DB (e.g. to fetch session data).
I think this is a fair compromise as...
- We only need both in one place (vs. all other methods touched in this PR)
- Fetching from the DB is the quick / "cheap" part of the function that's being called under the hood - and our GraphQL client (or DB / Hasura) is very likely doing some caching of these requests for us anyway.
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/simplify-redaction-handling
branch
from
d1e6951 to
e2f5b55
Compare
jessicamcinchak
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
planx-coreto pick up the changes implemented in refactor: Make redaction explicit inExportClientplanx-core#162computeBOPSParams()function. Local testing indicates that this approximately halves the time it takes to hit the/adminendpoints being updated here.